Preserve PR diff scroll position#8618
Closed
raashish1601 wants to merge 1 commit intomicrosoft:mainfrom
Closed
Conversation
alexr00
reviewed
Apr 1, 2026
| import { FileChangeModel, GitFileChangeModel, InMemFileChangeModel, RemoteFileChangeModel } from '../fileChangeModel'; | ||
| import { TreeNode, TreeNodeParent } from './treeNode'; | ||
|
|
||
| const pullRequestDiffViewStates = new Map<string, vscode.Range>(); |
Member
There was a problem hiding this comment.
We should try to avoid adding globals like this.
| this.changeModel.status, | ||
| ); | ||
| this.command = { | ||
| command: 'pr.openDiffView', |
Member
There was a problem hiding this comment.
We should continue to use the openDiffCommand. Maybe VS Code core's diff editor could instead be better about remembering the scroll position.
Member
|
Thank you for the PR, but I think this would be better solved by VS Code's diff editor better remembering scroll position. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8206.
Summary:
Validation:
npm run compile:testnpm run compile:nodenpx eslint src/commands.ts src/view/treeNodes/fileChangeNode.ts src/test/view/fileChangeNode.test.tsnpm testcould not complete here because the Windows VS Code Insiders binary rejected the extension-host CLI flags in this environment.Manual risk: